Fix 20 bugs from full codebase review#161
Merged
gvonness-apolitical merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
Multi-agent review across all 14 production modules with independent verification scoring. Key fixes: - Config: getConfig() bypassed user config at all entry points; add initRuntimeConfig() cache, wire to MCP server/hooks/dashboard - Config: parseInt/parseFloat NaN from env vars not validated - Ingest: findDebriefTurn returned array index instead of turn.index, breaking debrief edges during incremental ingestion - MCP: days_back=0 silently overrode explicit from/to date filters - MCP: missing params validation on tools/call JSON-RPC handler - MCP: parse error response used id:0 instead of id:null (JSON-RPC spec) - Storage: memory leak in vector index cleanup, stale projectsCache, hash collision in cluster membership, missing transaction wrapper - Retrieval: anyChildEmitted set unconditionally in chain-walker DFS - Hooks: session-start fallback never passed to executeHook(); withRetry() never updated metrics.retryCount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full multi-agent codebase review across all 14 production modules (v0.10.1). Each module was reviewed by parallel specialist agents (bug hunter, guidelines, error handling, architecture, test coverage) with independent verification scoring (threshold ≥80).
20 fixes applied across 20 files:
getConfig()returned defaults at all entry points, ignoring user config files and env vars. AddedinitRuntimeConfig()cache and wired it into MCP server, hooks, and dashboard. Also added NaN validation for parseInt/parseFloat from env vars, and range checks for clusterHour/halfLifeHours/decayFactor.findDebriefTurnreturned array index instead ofturn.index, silently breaking debrief edge creation during incremental ingestion.days_back: 0silently overrode explicit from/to; missing params validation ontools/call; parse error usedid: 0instead ofid: null(JSON-RPC 2.0 spec).anyChildEmittedset unconditionally in chain-walker DFS for agent-filtered/oversized branches.executeHook();withRetry()never updatedmetrics.retryCount.Cross-cutting patterns identified:
Test plan
npx causantic health)